Fix validate_chain_list() colnames check to compare all chains#529
Merged
jgabry merged 6 commits intostan-dev:masterfrom Apr 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes validate_chain_list() so column-name consistency is validated across all chains (not just chains 1 and 2), preventing silent acceptance of mismatched parameter names/order in chains 3+.
Changes:
- Replaced
sapply(x, colnames)simplification logic withlapply(x, colnames)to avoid matrix/list ambiguity. - Updated the equality check to compare every chain’s
colnames()against chain 1 viavapply(..., identical, ...).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 99.18% 99.18% -0.01%
==========================================
Files 35 35
Lines 6120 6118 -2
==========================================
- Hits 6070 6068 -2
Misses 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jgabry
approved these changes
Apr 15, 2026
Member
jgabry
left a comment
jgabry
left a comment
There was a problem hiding this comment.
Thanks, this is a good fix and the code is even cleaner than the original.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #528
identical(cnames[, 1], cnames[, 2])only validated colnames of chains 1 and 2, silently ignoring mismatches in chains 3+sapplywithlapply+vapplyto avoid matrix/list type ambiguity and compare all chains against the first